Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert IIIFAuthentication to a function. #3998

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Convert IIIFAuthentication to a function. #3998

merged 1 commit into from
Dec 2, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Nov 20, 2024

No description provided.

@cbeer cbeer requested a review from marlo-longley November 21, 2024 15:25
@cbeer cbeer marked this pull request as ready for review November 21, 2024 15:25
marlo-longley
marlo-longley approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested this with the internal /auth.html fixture page, and all 3 flows worked correctly.

@cbeer cbeer merged commit cac3ae2 into master Dec 2, 2024
6 of 7 checks passed
@cbeer cbeer deleted the auth-fn branch December 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlo-longley marlo-longley marlo-longley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeer @marlo-longley