Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CollectionDialog to a function. #3995

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Convert CollectionDialog to a function. #3995

merged 1 commit into from
Dec 2, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Nov 20, 2024

No description provided.

@cbeer cbeer requested a review from marlo-longley November 21, 2024 15:26
@cbeer cbeer marked this pull request as ready for review November 21, 2024 15:26
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm when I add this collection using the + UI and then click to view it, I get this

https://iiif.io/api/cookbook/recipe/0032-collection/collection.json

Screenshot 2024-11-27 at 7 32 44 PM

It looks like the root error might be:
Screenshot 2024-11-27 at 7 37 00 PM

marlo-longley
marlo-longley previously approved these changes Nov 28, 2024
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake please ignore.

@cbeer cbeer merged commit 30b66ce into master Dec 2, 2024
6 of 7 checks passed
@cbeer cbeer deleted the cd-function branch December 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants