Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Workspace components to functions #3993

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Nov 20, 2024

No description provided.

@cbeer cbeer requested a review from marlo-longley November 21, 2024 15:26
@cbeer cbeer marked this pull request as ready for review November 21, 2024 15:26
@cbeer cbeer force-pushed the function-components branch from 4b0fd22 to 18ca519 Compare November 26, 2024 18:44
@cbeer cbeer marked this pull request as draft November 26, 2024 18:53
@cbeer cbeer force-pushed the function-components branch from 18ca519 to 8017680 Compare November 26, 2024 19:25
@cbeer cbeer force-pushed the function-components branch from 8017680 to cc0afc9 Compare November 26, 2024 19:41
@cbeer cbeer marked this pull request as ready for review November 26, 2024 20:55
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion makes sense to me, and testing this branch with both elastic and mosaic layouts works as expected. Thanks for this work!

@cbeer cbeer merged commit f956d2a into master Dec 2, 2024
6 of 7 checks passed
@cbeer cbeer deleted the function-components branch December 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants