Remove react-sizeme to silence findDOMNode deprecation warnings #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
no-sizme
branch
from
1afb28a to
19c2694
Compare
marlo-longley
changed the title
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-nodeThis was caused by the
react-sizemelibrary. See ctrlplusb/react-sizeme#231It seemed fairly straightforward to replace the library with our own HOC since the ResizeObserver is browser native. Since it uses hooks I had to convert the
CompanionWindowcomponent to functional. The diff onCompanionWindowlooks big mostly because of re-indenting, but I really did not change any of the internal code (as in, I don't think this PR made any of changes that codeclimate hates).