Refactor manifesto initialization to push property localization down #3871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #3482:
This does the same thing as #3482, without introducing new redux state or a new selector parameter, in order to maintain API compatibility for downstream plugins. Instead, this PR:
LocaleContext
and locale-context awareIIIFResourceLabel
for rendering e.g. manifest, canvas, etc labels appropriately, replacing a lot of piece-meal label functionsgetLocale
/getManifestLocale
to work right... this is somewhat unfortunate, but probably less weird if we started to use hooks or more extensive use of context like Use context to pass the window id around #3661 (and a companion-window equivalent))This can be tested at https://deploy-preview-3871--mirador-dev.netlify.app/__tests__/integration/mirador/i18n.html
Fixes #3470