-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React 18 #3864
Update to React 18 #3864
Conversation
122d8ae
to
28488ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3864 +/- ##
==========================================
- Coverage 92.53% 92.43% -0.11%
==========================================
Files 203 203
Lines 3579 3581 +2
==========================================
- Hits 3312 3310 -2
- Misses 267 271 +4 ☔ View full report in Codecov by Sentry. |
Hi, I'm stopping by after a discussion on Slack IIIF. We are putting some effort to upgrade the plugin here : https://gitlab.tetras-libre.fr/iiif/mirador/mirador-annotations The strategy is to follow what's happening on the Mirador side. We first target an upgrade to React17 and MUI5 (against the corresponding In the process we also target major UI improvements, video annotation support, etc. Finally, our first investigations towards a React18 upgrade showed that the paper.js library that is used in Anyway, I think that an in place replacement for paper.js would be very welcome, if not absolutely necessary. Any input on the matter is very welcome. |
Thanks for all the work on this, @cbeer! I've tested this branch in a project we're (https://github.com/artshumrc) working on right now. I did not find any issue or regressions with the core Mirador viewer. Progress seems to be going well for this upgrade. With the below exceptions, it was essentially a drop-in replacement that worked. I'm sure it is no surprise that I needed to disable our image-tools and annotations plugins in order to build and run this version. It would be easier for us to test these upgrades in a real world project if there was a prelease distribution that we could include in our CI/CD pipeline. Perhaps I am missing something obvious, but the only way I found to test this branch in our project was to build from source myself and include the distribution in our project. |
Merging per Mirador Community Call 3/14 |
No description provided.