Fix some styling and console errors on mui5 branch #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
companion-fixes
branch
from
32765d3 to
38c36a6
Compare
marlo-longley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix attribution panel padding:
Restore divider
Restore shadow to app top bar using zindex.
I'm not sure exactly how it was removed in the mui5 work, but in the current version of Mirador it was a z-index of 1100.
Remove invalid props
alignItemsandbuttonwere causing a console errorsI removed
buttonfromMuiListItem. Visually I can't tell any difference but not sure the history here. According to MUI,MuiListItemalso has access to props ofButtonBase-- so it can act like a button inherently. ?