Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent item labels in Collection modal from being cut off #3432

Merged
merged 3 commits into from
May 19, 2021

Conversation

regisrob
Copy link
Contributor

@regisrob regisrob commented May 3, 2021

@codecov-commenter
Copy link

Codecov Report

Merging #3432 (e707c1b) into master (f04f89f) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

❗ Current head e707c1b differs from pull request most recent head fab63ef. Consider uploading reports for the commit fab63ef to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3432      +/-   ##
==========================================
- Coverage   88.99%   88.94%   -0.06%     
==========================================
  Files         196      196              
  Lines        3398     3400       +2     
==========================================
  Hits         3024     3024              
- Misses        374      376       +2     
Impacted Files Coverage Δ
src/components/CollectionDialog.js 54.16% <25.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04f89f...fab63ef. Read the comment docs.

@camillevilla camillevilla self-requested a review May 7, 2021 19:31
@cbeer
Copy link
Collaborator

cbeer commented May 12, 2021

I've added a screenshot above. @ggeisler, does this look ok?

@ggeisler
Copy link
Collaborator

@regisrob @cbeer Yes, this looks great to me.

That screenshot illustrates another minor styling issue: the main content area (from the Resource heading down) needs to be indented an additional 10px or so so that it is left-aligned with the header content. But that is a different issue so I can create a separate ticket for that if we want to keep this one simple and get it merged.

@cbeer cbeer merged commit 584466c into ProjectMirador:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item labels are cut off in the Collection modal
4 participants