Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

∀ is a keyword and alias for forall in PureScript #3005

Merged
merged 1 commit into from
Jul 23, 2021
Merged

∀ is a keyword and alias for forall in PureScript #3005

merged 1 commit into from
Jul 23, 2021

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Jul 22, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 22, 2021 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +10 B (+2.2%).

file master pull size diff % diff
components/prism-purescript.min.js 455 B 465 B +10 B +2.2%

Generated by 🚫 dangerJS against 8e72dd0

@toastal toastal mentioned this pull request Jul 22, 2021
Closed
RunDevelopment
RunDevelopment requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @toastal!

Please rebuild Prism (npm run build after npm ci) and add the new keyword to the keyword test (and update the test). Otherwise, the PR is gtg!

@toastal toastal force-pushed the purescript-forall branch from 438a16d to eebaea7 Compare July 23, 2021 06:58
@toastal
Copy link
Contributor Author

toastal commented Jul 23, 2021

Please rebuild Prism (npm run build after npm ci) and add the new keyword to the keyword test (and update the test). Otherwise, the PR is gtg!

I think we are good? Ran for me on Node 14.x locally

@toastal toastal force-pushed the purescript-forall branch from eebaea7 to 8e72dd0 Compare July 23, 2021 10:50
@RunDevelopment RunDevelopment merged commit b38fc89 into PrismJS:master Jul 23, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @toastal!

@sync-by-unito sync-by-unito bot mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment requested changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toastal @RunDevelopment