Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blocks): add BlockDocument HTTP client #178

Merged
merged 5 commits into from
May 30, 2024
Merged

feat(blocks): add BlockDocument HTTP client #178

merged 5 commits into from
May 30, 2024

Conversation

parkedwards
Copy link
Contributor

@parkedwards parkedwards commented May 30, 2024 •
edited
Loading

resolves #173

adds:

  • BlockDocumentClient - with Get, Create, Update, and Delete methods
  • a subset of ^ client for /access, to manage attached ACL objects - specifically:
    • GetACL (GET /block_documents/{id}/access)
    • UpdateACL (PUT /block_documents/{id}/access)

@parkedwards parkedwards requested review from gabcoyne and a team as code owners May 30, 2024 01:13
@parkedwards parkedwards temporarily deployed to Acceptance Tests May 30, 2024 01:13 — with GitHub Actions Inactive
mitchnielsen
mitchnielsen requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Eddie, looks great. Two quick questions and one tiny suggestion.

internal/client/block_documents.go Outdated Show resolved Hide resolved
internal/api/block_documents.go Outdated Show resolved Hide resolved
@parkedwards parkedwards temporarily deployed to Acceptance Tests May 30, 2024 17:12 — with GitHub Actions Inactive
@parkedwards parkedwards temporarily deployed to Acceptance Tests May 30, 2024 17:16 — with GitHub Actions Inactive
@parkedwards parkedwards requested a review from mitchnielsen May 30, 2024 17:46
@mitchnielsen
Copy link
Contributor

🎉 🚢

@parkedwards parkedwards merged commit b75d6c4 into main May 30, 2024
7 checks passed
@parkedwards parkedwards deleted the feat/block-docs-http branch May 30, 2024 20:11
@mitchnielsen mitchnielsen mentioned this pull request May 31, 2024
Merged
@parkedwards parkedwards added the enhancement New feature or request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchnielsen mitchnielsen mitchnielsen approved these changes

@gabcoyne gabcoyne Awaiting requested review from gabcoyne

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocks Support: Add BlockDocument HTTP client + struct model
2 participants
@parkedwards @mitchnielsen