Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label all resources in lineage events #16471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abrookins
Copy link
Collaborator

We changed how we decide if a resource on an event is a "lineage" resource. Now, a resource must have the prefect.resource.lineage-group label to be considered a lineage resource. In order to capture lineage relationships with flows and other objects, we attach prefect.resource.lineage-group to all resources passed in and all related resources we discover.

NOTE: This leaves callers with no way to specify that a resource is related but not a lineage resource. In the short term, this is OK. In the long term, one way that users might specify this is adding prefect.resource.lineage-group=None to resources they want to appear in the event but not on the lineage dashboard.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Dec 21, 2024

CodSpeed Performance Report

Merging #16471 will not alter performance

Comparing label-all-resources-in-lineage-events (ccebf33) with main (6f5d463)

Summary

✅ 3 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant