Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adding concurrency-limit-task-run-card component #16444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UI v2] feat: Adding concurrency-limit-task-run-card component #16444

wants to merge 1 commit into from
+447 −3

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 18, 2024 •
edited
Loading

  1. Create route placeholder for /runs/task-run/$id
  2. Ports over @/utilities/seconds
  3. Adds RunCard component to be used

Screenshot 2024-12-21 at 1 08 54 PM
Screenshot 2024-12-21 at 1 08 59 PM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Dec 18, 2024
devinvillarosa
devinvillarosa commented Dec 18, 2024
View reviewed changes
ui-v2/src/storybook/utils/router-decorator.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on: https://gist.github.com/jaens/693bd767b0f18d6577265815f6831c7a
TanStack/router#952

A bit quick and dirty way of doing it, but I just want to be able to use @tanstack/react-router components to be used in Storybook stories

@devinvillarosa devinvillarosa force-pushed the concurrency-limitr-task-run-card branch from e08e3bc to 1b0e12d Compare December 18, 2024 22:17
devinvillarosa
devinvillarosa commented Dec 18, 2024
View reviewed changes
ui-v2/src/utilities/seconds.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported over from other repo

devinvillarosa
devinvillarosa commented Dec 18, 2024
View reviewed changes
ui-v2/src/routes/runs/task-run.$id.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add for <Link> component

@devinvillarosa devinvillarosa force-pushed the concurrency-limitr-task-run-card branch from 1b0e12d to f30d85b Compare December 18, 2024 22:27
devinvillarosa
devinvillarosa commented Dec 18, 2024
View reviewed changes
ui-v2/src/components/ui/tag-badge-group.tsx
@@ -3,14 +3,14 @@ import { HoverCard, HoverCardContent, HoverCardTrigger } from "./hover-card";
import { TagBadge } from "./tag-badge";

type TagBadgeGroupProps = {
tags: string[];
tags: string[] | undefined;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for + dev x.
Schema says tags is optional, so handling undefined to default to an empty string

@devinvillarosa devinvillarosa marked this pull request as ready for review December 18, 2024 22:32
@devinvillarosa devinvillarosa force-pushed the concurrency-limitr-task-run-card branch 2 times, most recently from 887d012 to 4e28f9e Compare December 20, 2024 03:31
@aaazzam
Copy link
Collaborator

aaazzam commented Dec 20, 2024

@devinvillarosa IIRC was have "RunCards" like this all over. What's "concurrency"-y about this component?

@devinvillarosa devinvillarosa force-pushed the concurrency-limitr-task-run-card branch from 4e28f9e to 4424975 Compare December 20, 2024 22:39
@devinvillarosa
Copy link
Contributor Author

@devinvillarosa IIRC was have "RunCards" like this all over. What's "concurrency"-y about this component?

ahh makes sense.
I think this may be the first one for re-platforming.

I don't mind revisiting this and make a more generic RunCard UI component to be used instead once we tackle it in another page

@devinvillarosa devinvillarosa force-pushed the concurrency-limitr-task-run-card branch 2 times, most recently from d577f94 to e08d97f Compare December 21, 2024 21:12
@devinvillarosa
Copy link
Contributor Author

@devinvillarosa IIRC was have "RunCards" like this all over. What's "concurrency"-y about this component?

Actually, I see what you mean. I updated the component to be just RunCard where it can render for task runs or flow runs.
But the flow runs will probably need to re-visit this component when we develop the Flow Run card to add additional features like onSelect, params, etc

Screenshot 2024-12-21 at 1 08 54 PM
Screenshot 2024-12-21 at 1 08 59 PM

@devinvillarosa devinvillarosa force-pushed the concurrency-limitr-task-run-card branch from e08d97f to fe9e370 Compare December 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @aaazzam