Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter deployments by any tag #16400

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Filter deployments by any tag #16400

wants to merge 8 commits into from

Conversation

brunifrancesco
Copy link

@brunifrancesco brunifrancesco commented Dec 16, 2024 •
edited by zzstoatzz
Loading

closes 16398

@github-actions github-actions bot added enhancement An improvement of an existing feature docs ui-replatform Related to the React UI rewrite labels Dec 16, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16400 will not alter performance

Comparing brunifrancesco:fix-for-issue-16398 (1dbc247) with main (cc2d678)

Summary

✅ 3 untouched benchmarks

zzstoatzz
zzstoatzz approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you

tests/client/test_prefect_client.py
prefect_client, deployment_tags, filter_tags, expected_match
):
@flow
def moo_deng():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦛

@zzstoatzz
Copy link
Collaborator

my fault @brunifrancesco - I broke this when resolving a conflict! will fix

@aaazzam aaazzam added enhancement An improvement of an existing feature and removed enhancement An improvement of an existing feature docs ui-replatform Related to the React UI rewrite labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@discdiver discdiver Awaiting requested review from discdiver discdiver is a code owner

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeploymentFilterTags should have an _any option
3 participants
@brunifrancesco @zzstoatzz @aaazzam