Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Scaffolds concurrency-limit route #16370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 12, 2024

  1. Flattens component file structure with verbose names (Cause for many file change diffs)
  2. Adds route and loader for /concurrency-limits/concurrency-limit/:id.
  3. Adds UX components for route above (with tests).
  4. Adds stories for flattened components
  5. Updates styling from latest biome version

Apologies for the large file diffs due to flattening file, but I think this is a good pattern to copy for other /components/<FOLDER>

Screen.Recording.2024-12-12.at.3.24.07.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to: #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Dec 12, 2024
Copy link
Contributor Author

@devinvillarosa devinvillarosa Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to delete this test, but now that this table now uses <Link /> and a dependency of react-router, I couldn't figure out how to get this test running

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need a tab component? Seems like this page only has this option

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the tab for now, but can we make it so it doesn't stretch across the screen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest push now has it to just have minimal space

Screenshot 2024-12-18 at 9 03 52 AM

@devinvillarosa devinvillarosa force-pushed the load-data-and-scaffold branch 2 times, most recently from 738d141 to 8ac77d9 Compare December 12, 2024 23:35
@devinvillarosa devinvillarosa marked this pull request as ready for review December 12, 2024 23:38
@devinvillarosa devinvillarosa force-pushed the load-data-and-scaffold branch 5 times, most recently from fdb019f to a8bd7e1 Compare December 20, 2024 22:42
@devinvillarosa devinvillarosa force-pushed the load-data-and-scaffold branch 7 times, most recently from cfe8a7f to 75a381d Compare December 23, 2024 02:07
@devinvillarosa devinvillarosa marked this pull request as draft December 23, 2024 02:41
@devinvillarosa devinvillarosa marked this pull request as ready for review December 23, 2024 02:44
@devinvillarosa devinvillarosa marked this pull request as draft December 23, 2024 04:55
@devinvillarosa devinvillarosa marked this pull request as ready for review December 23, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants