Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Monthly 2022 11 #1349

Closed
wants to merge 37 commits into from
Closed

[WIP] Monthly 2022 11 #1349

wants to merge 37 commits into from

Conversation

Neopallium
Copy link
Contributor

@Neopallium Neopallium commented Nov 21, 2022 •
edited
Loading

Applying changes needed for Substrate monthly 2022-11.

  • Fix RPC code.
  • Fix building of tests.
  • Make sure all Substrate pallet migrations are included and working.
  • Review changes to pallets/balances/src/lib.rs.
  • Replace the uses of deprecated remove_prefix() with clear_prefix.
  • Review changes to Substrate's transaction-payment pallet and port those changes as needed (i.e. LengthToFee and WeightToFee traits).
  • Update weights template file and re-run all benchmarks.
  • Bump Runtime API version from 1 -> 2 of the transaction-payment APIs.

changelog

new features

  • [new feature, schema, events, RPC]

modified API

  • [modified APIs, schema, events, RPC]

modified logic

  • [modified behaviour, bug fixes]

modified agent functionality

  • [the addition or removal of any extrinsics or events emitted by those extrinsics, that relate to permissioned agents]

data migration required

  • [storage modified during upgrade process - provide details]

Neopallium
Neopallium commented Nov 22, 2022
View reviewed changes
pallets/sudo/src/lib.rs Outdated Show resolved Hide resolved
Neopallium
Neopallium commented Nov 22, 2022
View reviewed changes
pallets/transaction-payment/src/lib.rs
Comment on lines +208 to +221
// TODO: Handle all weight dimensions
let normal_max_weight = normal_max_weight.ref_time();
let normal_block_weight = normal_block_weight.ref_time();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. This was copied as-is from Substrate's transaction-payment pallet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we don't use TargetedFeeAdjustment.

@Neopallium Neopallium mentioned this pull request Nov 22, 2022
Merged
@Neopallium Neopallium force-pushed the monthly-2022-11 branch 3 times, most recently from b70c715 to c14a766 Compare November 23, 2022 14:01
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #1349 (4ea375e) into develop (d72599a) will increase coverage by 10.61%.
The diff coverage is 23.03%.

@@             Coverage Diff              @@
##           develop    #1349       +/-   ##
============================================
+ Coverage    43.35%   53.96%   +10.61%     
============================================
  Files          140      140               
  Lines        30145    30421      +276     
============================================
+ Hits         13069    16417     +3348     
+ Misses       17076    14004     -3072
Impacted Files Coverage Δ
pallets/asset/src/checkpoint/mod.rs 57.70% <0.00%> (+2.75%) ⬆️
pallets/base/src/lib.rs 51.78% <0.00%> (ø)
pallets/common/src/traits/asset.rs 0.00% <ø> (ø)
pallets/common/src/traits/external_agents.rs 0.00% <ø> (ø)
pallets/common/src/traits/group.rs 49.27% <0.00%> (ø)
pallets/common/src/traits/identity.rs 3.65% <0.00%> (ø)
pallets/common/src/traits/mod.rs 0.00% <ø> (ø)
pallets/common/src/traits/portfolio.rs 0.00% <ø> (ø)
pallets/common/src/traits/relayer.rs 0.00% <ø> (ø)
pallets/common/src/traits/statistics.rs 0.00% <ø> (ø)
... and 115 more

@Neopallium Neopallium force-pushed the monthly-2022-11 branch 3 times, most recently from 1226778 to 4bf1cdd Compare December 12, 2022 16:18
@Neopallium Neopallium force-pushed the monthly-2022-11 branch 2 times, most recently from a615a0c to c8d7761 Compare December 22, 2022 14:01
@Neopallium Neopallium force-pushed the monthly-2022-11 branch 2 times, most recently from a14c85b to eeaf1ed Compare January 13, 2023 17:02
@Neopallium Neopallium force-pushed the monthly-2022-11 branch 3 times, most recently from c3d64e6 to e1ef16b Compare January 19, 2023 09:08
@Neopallium
Fixup.
2e98fbc
@Neopallium
Allow use of kill_prefix
933d77f
@Neopallium
FIXUP: Settlement weights.
26f307d
@Neopallium
Fix issue with schedule weight limit.
928c6a9
@Neopallium
Fix contracts GAS_LIMIT to include a proof_size.
243aa3b
@Neopallium
Fix expected bridge weights in tests.
2a8d026
@Neopallium
Add missing migrations.
dd37154
@Neopallium
Fixup: transaction payment RPC endpoints.
caa2f9c
@Neopallium
Cargo lock updates.
5b57917
@Neopallium
Apply commit
3b5e536 
paritytech/substrate@419924c

To our fork.
@Neopallium
Add more changes from Substrate balances pallet.
122cc19
@Neopallium
Update benchmark weights template.
72cbfa7
@Neopallium
Update weights type name.
4ee04ec
@Neopallium
Charge minimal fee if the caller is not authorized.
dc2a9f7
@Neopallium
Update weights.
5c2c6f2
@Neopallium
Update weights in bridge tests.
d75689a
@Neopallium
Update Substrate crates.
ec9316b
@Neopallium
Code cleanup in transaction-payment.
e20c6eb 
Make the code closer to Substrate's transaction-payment code.
@Neopallium
Copy link
Contributor Author

Closing this PR. The Dec monthly PR #1387 should be the one to merge.

@Neopallium Neopallium closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Neopallium