Infinity should be treated as plural #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In plural.js, `parseInt()`[0] is used to check if the given input is a number. However the radix argument for `parseInt()` is omitted which can produce unexpected behaviors; this is discouraged by the MDN[1]. Anyways if we are using Infinity (for example with `$ngettext(singular, plural, Infinity)`) then the expected translation should be plural instead of singular. [0] https://tc39.es/ecma262/#sec-parseint-string-radix [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt
|
The radix of Quoting the ES 2020 spec you referenced:
But I like the explicit conversion with Thanx @nterray |
|
New release available: https://github.com/Polyconseil/vue-gettext/releases/tag/v2.1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In plural.js,
parseInt()[0] is used to check if the given input is anumber. However the radix argument for
parseInt()is omitted which canproduce unexpected behaviors; this is discouraged by the MDN[1].
Anyways if we are using Infinity (for example with
$ngettext(singular, plural, Infinity)) then the expected translation should be plural instead ofsingular.
[0] https://tc39.es/ecma262/#sec-parseint-string-radix
[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt