Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PValue ordering #524

Merged
merged 4 commits into from
Jul 20, 2022
Merged

PValue ordering #524

merged 4 commits into from
Jul 20, 2022

Conversation

TotallyNotChase
Copy link
Collaborator

@TotallyNotChase TotallyNotChase commented Jul 19, 2022 •
edited
Loading

POrd instance for PValue - with a somewhat optimized implementation.

Also some type signature fixes

Can't add tests right now - might try to later. But it's not like other value stuff have tests either...

@TotallyNotChase
Copy link
Collaborator Author

TotallyNotChase commented Jul 19, 2022 •
edited
Loading

Fourmolu breaks with

  AST of input and AST of formatted code differ.
    at Plutarch/Api/V1/Value.hs:127:12-47
    at Plutarch/Api/V1/Value.hs:130:12-47
  Please, consider reporting the bug.

I don't know how to fix this.

TotallyNotChase
TotallyNotChase commented Jul 19, 2022
View reviewed changes
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Show resolved Hide resolved
L-as
L-as requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It seems like we're in fact not vulnerable to #490, because their issue is that they don't represent innullity in the types.

Plutarch/Api/V1/AssocMap.hs Show resolved Hide resolved
Plutarch/Api/V1/AssocMap.hs Show resolved Hide resolved
Plutarch/Api/V1/AssocMap.hs Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
Plutarch/Api/V1/Value.hs Outdated Show resolved Hide resolved
@L-as
Copy link
Member

L-as commented Jul 20, 2022

Maybe you want to η-reduce then we can merge?

L-as
L-as approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-as L-as merged commit 273552f into staging Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-as L-as L-as approved these changes

@blamario blamario Awaiting requested review from blamario

@MangoIV MangoIV Awaiting requested review from MangoIV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TotallyNotChase @L-as