Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PAsData from TxInfo where it is redundant #521

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Drop PAsData from TxInfo where it is redundant #521

merged 1 commit into from
Jul 14, 2022

Conversation

emiflake
Copy link
Collaborator

Summary:

  • For both V1 and V2 PTxInfo, I dropped unnecessary PAsDatas, since PSubtype PData a for those types.
  • Replaced all instances of PIsData (PBuiltinList a) with one that uses PSubtype.
  • Added plistData, a wrapper for the ListData builtin.

@emiflake emiflake requested review from L-as and TotallyNotChase July 14, 2022 21:01
L-as
L-as approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@L-as L-as merged commit 829f7d6 into staging Jul 14, 2022
@L-as L-as mentioned this pull request Sep 6, 2022
Open
@emiflake emiflake deleted the emiflake/drop-as-data-api branch October 24, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-as L-as L-as approved these changes

@TotallyNotChase TotallyNotChase Awaiting requested review from TotallyNotChase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emiflake @L-as