Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating RFC for Visualization tools. #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Creating RFC for Visualization tools. #11

wants to merge 4 commits into from

Conversation

JuanSolisCTJ13
Copy link

RFC for Viz Tools in the data monitoring squad.

@JuanSolisCTJ13
Creating RFC for Visualization tools.
3de6b16 
RFC for Viz Tools in the data monitoring squad.
@JuanSolisCTJ13
Update 0000-RFC-for-viz-tools .md
4bdfd4b 
Just in the process...
@JuanSolisCTJ13
Copy link
Author

@YaelRmz please include your comments here.

JuanSolisCTJ13
JuanSolisCTJ13 commented Mar 1, 2022
View reviewed changes
Copy link
Author

@JuanSolisCTJ13 JuanSolisCTJ13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaelRmz

nazlonga
nazlonga requested changes Mar 11, 2022
View reviewed changes
Copy link

@nazlonga nazlonga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have discussed in the Slack, please add in the adaptation strategy, that initially we could use Streamlit to generate the first versions of the dashboards, and later the d3.js library.

@JuanSolisCTJ13
including changes in the adaptation strategy
67d32d2 
only changes in the adoption methodology
@JuanSolisCTJ13
Copy link
Author

As we have discussed in the Slack, please add in the adaptation strategy, that initially we could use Streamlit to generate the first versions of the dashboards, and later the d3.js library.

it's ok, can you check please

adrian0fernandez
adrian0fernandez reviewed Mar 16, 2022
View reviewed changes
Copy link

@adrian0fernandez adrian0fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there are some blank paragraphs and spaces. Specifcally in "Basic example", "detailed design".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian0fernandez adrian0fernandez adrian0fernandez left review comments

@nazlonga nazlonga nazlonga requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanSolisCTJ13 @nazlonga @adrian0fernandez