Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Create prices detail card #178

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jscalle
Copy link

@jscalle jscalle commented Apr 30, 2022

Create prices detail card

@jscalle
Copy link
Author

jscalle commented Apr 30, 2022

Summary

This solves issue #148

Copy link
Contributor

@elyager elyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside components rename the App.js component to something more accurate to what it represents, check how searching-engine squad did the components division

All this files should be inside a folder that represents the component: 👇
CleanShot 2022-05-02 at 9 45 13

@jscalle jscalle requested a review from elyager May 4, 2022 02:30
@jscalle
Copy link
Author

jscalle commented May 4, 2022

image

This way, the card code remains inside its respective folder

@jscalle jscalle removed the request for review from Wiliberto May 6, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants