Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nit] Gracefully report missing env variable instead of panicking #54

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[nit] Gracefully report missing env variable instead of panicking #54

merged 1 commit into from
Dec 11, 2024

Conversation

blefaudeux
Copy link
Contributor

fix #52, added a unit test to nail it

@blefaudeux
Copy link
Contributor Author

cc @tarek-ayed, a bit nicer now

@blefaudeux blefaudeux merged commit e4ff54a into main Dec 11, 2024
2 checks passed
@blefaudeux blefaudeux deleted the ben/graceful_env_report branch December 11, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seddarj seddarj seddarj approved these changes

@tarek-ayed tarek-ayed Awaiting requested review from tarek-ayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Gracefully report missing env variables
2 participants
@blefaudeux @seddarj