Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding contributing guidelines (#32) #33

Merged
merged 1 commit into from
Feb 2, 2024
Merged

adding contributing guidelines (#32) #33

merged 1 commit into from
Feb 2, 2024

Conversation

iannesbitt
Copy link
Contributor

Adding CONTRIBUTING.md to the repo per our discussion yesterday.

Issue:

@iannesbitt iannesbitt added the documentation Improvements or additions to documentation label Feb 2, 2024
@iannesbitt iannesbitt requested a review from robyngit February 2, 2024 18:12
@iannesbitt iannesbitt self-assigned this Feb 2, 2024
@iannesbitt iannesbitt requested review from robyngit and removed request for robyngit February 2, 2024 18:23
@iannesbitt
Copy link
Contributor Author

@robyngit I forgot you're off on Fridays! Added, removed, then re-added you for a very brief review task of the contributing guidelines.

@iannesbitt iannesbitt requested a review from mbjones February 2, 2024 18:43
mbjones
mbjones approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@mbjones mbjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good (although I didn't carefully proofread it). It would also be good to be sure the build and test infrastructure are actually in place. I am working on that for the other viz-* repositories.

@iannesbitt
Copy link
Contributor Author

Agreed. Tests are discussed in #12 and #26, but I have not yet implemented sufficient coverage.

@iannesbitt iannesbitt merged commit b173488 into main Feb 2, 2024
@iannesbitt iannesbitt removed the request for review from robyngit February 2, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbjones mbjones mbjones approved these changes

Assignees

@iannesbitt iannesbitt

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iannesbitt @mbjones