Add Platform API and babel plugin #26
Conversation
src/preload.ts
Outdated
| platform, | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
In our case, we implemented the node integration without context isolation.
So I add the auto fallback.
Or you suggest us refactor?
There was a problem hiding this comment.
My understanding is that context isolation is ennabled default in Electron now, I haven't seen docs about injecting globals when context isolation is disabled?
Basically, I don't want to rely on undefined Electron behavior for injecting these APIs. If the way you changed it is recommended or at least documented by Electron that's fine, but otherwise I'd rather only use the contextBridge API.
There was a problem hiding this comment.
In my test. Disable the context isolation, contextBridge.exposeInMainWorld will throw error.
Error: contextBridge API can only be used when contextIsolation is enabled
As title.
In my case.
We need know which OS instead just
webAnd considered #5 , I move it to
nativeOS