Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Project No.2】 引入clang-tidy #903

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

【Hackathon 6th Fundable Project No.2】 引入clang-tidy #903

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
abfa71c
Create 20240514_introducing_clang_tidy.md
ApricityXX May 14, 2024
4efa405
Merge branch 'PaddlePaddle:master' into patch-1
ApricityXX May 15, 2024
5d515f3
modify docs of clang-tidy
ApricityXX May 15, 2024
23263f3
Update 20240514_introducing_clang_tidy.md
luotao1 May 16, 2024
2f8fe47
Merge branch 'PaddlePaddle:master' into patch-1
ApricityXX May 16, 2024
d91c43f
modify clang-tidy docs 5.16
ApricityXX May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions rfcs/CodeStyle/20240514_introducing_clang_tidy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,25 @@ readability-string-compare,

- 对于某些情况下，需要跳过 `clang-tidy` 检查的，可以使用 `NOLINT`, `NOLINTNEXTLINE`, `NOLINTBEGIN ... NOLINTEND` 来抑制检查诊断。

针对已经全部修复完的检查项，可以把`.clang-tidy`文件中中的对应项前面的`"-"`删除，以`modernize-use-emplace`举例：

假设所有的`modernize-use-emplace`错误项均修复完成，就可以在`.clang-tidy`文件中将其前面的"-"去掉，随着`modernize-use-emplace-final`的pr一起提交。

例如：

```
...
-modernize-replace-auto-ptr,
-modernize-replace-random-shuffle,
-modernize-shrink-to-fit,
-modernize-unary-static-assert,
modernize-use-bool-literals,
modernize-use-emplace,
...
```





### 4.2 引入CI
Expand Down