Infer CSV delimiter if it hasn't been set explicitly #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but we miss unit tests to be merged. Could you please add some, most likely in |
|
@PowerKiKi, thanks. I added a test. |
|
Thanks for your contribution ! I added a bit of documentation and changelog and merged everything as a squashed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to infer the delimiter if it hasn't been explicitly set. It first counts the number of occurrences of a number of potential delimiters (max. first 1000 lines) of a CSV file and then chooses the one which occurs most regularly (mean square deviation).