This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Implement actual timezone adjustment into PHPExcel_Shared_Date::PHPToExcel #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the little |
|
👍 I was just about to start a PR myself. Would love to see this fixed. |
|
Any idea if this is getting rebased and merged eventually? |
|
Thanks, now merged into the 1.8 branch |
|
I can not, for the life of me, find this fix in the 1.8 branch. Composer is downloading 1.8.1, and that fix is not there. Really puzzling. |
|
@sebastienbarre, you are looking for c4782b6, which is indeed on branch 1.8. But it was never released as part of PHPExcel. You should consider migrating to PhpSpreadsheet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having encountered issue #38 by accident I took the timezone adjustment code from ExcelToPHP conversion and also applied it here to fix the problem.