Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add new InvalidPackagesTest #168

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 5, 2022

Proposed Changes

This new test class tests that the plugin does not act on Composer packages which are not considered valid external PHPCS standards for the purposes of this plugin.

Notes:

  • This test is about Composer and the plugin, so does not need to be tested against multiple PHPCS versions.
  • The behaviour also shouldn't differ between a global vs local Composer install, so only testing one type.

Related to #92

This new test class tests that the plugin does not act on Composer packages which are not considered valid external PHPCS standards for the purposes of this plugin.

Notes:
* This test is about Composer and the plugin, so does not need to be tested against multiple PHPCS versions.
* The behaviour also shouldn't differ between a global vs local Composer install, so only testing one type.
@jrfnl jrfnl requested a review from a team March 5, 2022 16:14
@Potherca Potherca merged commit 29d3180 into master Apr 18, 2022
@Potherca Potherca deleted the feature/tests-new-invalidpackages-test branch April 18, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants