Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTTL should accept null #89

Closed
williamdes opened this issue Dec 23, 2021 · 1 comment · Fixed by #91
Closed

setTTL should accept null #89

williamdes opened this issue Dec 23, 2021 · 1 comment · Fixed by #91
Labels
bug Something isn't working

Comments

@williamdes
Copy link

Subject of the issue

setTTL should accept null in the phpdoc

Your environment:

Q A
Bug? yes
New Feature? no
Framework Laravel
Framework version 8.77
Package version 1.2.0
PHP version 7.4.25

Steps to reproduce

Use phpstan on this code

        $factory = JWTAuth::factory();
        $factory->setDefaultClaims($defaultClaims);
        $factory->validator()->setRequiredClaims($requiredClaims);
        $factory->setTTL(null);

Expected behaviour

Allow null ?

Actual behaviour

Parameter #1 $ttl of method PHPOpenSourceSaver\JWTAuth\Factory::setTTL() expects int, null given

@williamdes williamdes added the bug Something isn't working label Dec 23, 2021
@Messhias
Copy link
Collaborator

Subject of the issue

setTTL should accept null in the phpdoc

Your environment:

Q A
Bug? yes
New Feature? no
Framework Laravel
Framework version 8.77
Package version 1.2.0
PHP version 7.4.25

Steps to reproduce

Use phpstan on this code

        $factory = JWTAuth::factory();
        $factory->setDefaultClaims($defaultClaims);
        $factory->validator()->setRequiredClaims($requiredClaims);
        $factory->setTTL(null);

Expected behaviour

Allow null ?

Actual behaviour

Parameter #1 $ttl of method PHPOpenSourceSaver\JWTAuth\Factory::setTTL() expects int, null given

Hi, thanks for letting us know, if you already have the solution you're welcome to open the PR.

In case of not, I'll ask to you have some patience to investigate, I particularly am passing by a very turbulent end of the year because I'm doing 2 hiring processes at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants