Fixes from Fortitude linter #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 47 47
Lines 6760 6761 +1
Branches 764 764
=======================================
+ Hits 6276 6277 +1
Misses 472 472
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
With the current configuration and fortitude 0.6, only 4 errors remain.
JanosJiri
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies fixes from Fortitude linter, see #189 for more info.
You can install fortitude with uv (or pip/pipx)
uv tool install fortitude-lintAnd run it on the codebase
fortitude check src/Most of the fixes are adding the
intentattribute to functions/subroutine parameters, missing (or superfluous)implicit none, and missing kind parameter on number constants (0.5->0.5D0)In this PR I don't add Fortitude in CI (yet) since it is currently missing some configuration capability that we need. In particular, it's not possible to skip files. We need to skip
FFTW3.F90andforce_cp2k.F90. The former is autogenerated file that we should not touch. The latter for some reason contains some weird errors that I was too lazy to understand (and this file is not really important now).