-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set __all__
#72
Set __all__
#72
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
+ Coverage 60.61% 60.92% +0.30%
===========================================
Files 14 14
Lines 1521 1533 +12
===========================================
+ Hits 922 934 +12
Misses 599 599 ☔ View full report in Codecov by Sentry. |
1. Avoids littering the namespace on star imports more than necessary 2. Simplifies cross-references to documentation, e.g., in addition to `petab_select.problem.Problem`, we can also now reference `petab_select.Problem`. This wasn't possible before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Many methods aren't expected to be used by users directly (e.g. in misc.py
), but fine to doc them anyway
Co-authored-by: Dilan Pathirana <[email protected]>
Agreed. Feel free to remove those, I didn't want break anything already using petab_select. Merge at your convenience.
There is |
petab_select.problem.Problem
, we can also now referencepetab_select.Problem
. This wasn't possible before.