Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type annotations / docstrings #70

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Fix some type annotations / docstrings #70

merged 3 commits into from
Dec 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7c71053) 60.61% compared to head (e95f327) 60.64%.

Files Patch % Lines
petab_select/model_space.py 50.00% 1 Missing ⚠️
petab_select/problem.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
+ Coverage    60.61%   60.64%   +0.02%     
===========================================
  Files           14       14              
  Lines         1521     1522       +1     
===========================================
+ Hits           922      923       +1     
  Misses         599      599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl requested a review from dilpath December 16, 2023 19:38
dilpath
dilpath approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️

👍

@dweindl dweindl merged commit 72fc8c3 into develop Dec 16, 2023
3 checks passed
@dweindl dweindl deleted the fix_annot branch December 16, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweindl @codecov-commenter @dilpath