Add RTD config #63
Merged
Add RTD config #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some basic sphinx configuration.
WARNING: Cannot resolve forward reference in type annotations of "petab_select.misc.hash_parameter_dict": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.misc.hash_parameter_options": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.misc.hash_parameter_dict": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.misc.hash_parameter_options": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model.Model.get_parameter_values": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace.__init__": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace.get_estimated": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace.indices_to_parameters": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace.parameters_all": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace.parameters_to_indices": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace.parameters_to_model": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.decompress_parameter_values": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.decompress_parameter_values": name 'estimate' is not defined WARNING: Cannot resolve forward reference in type annotations of "petab_select.model_subspace.ModelSubspace": name 'estimate' is not defined
Merged
Codecov Report
@@ Coverage Diff @@
## develop #63 +/- ##
========================================
Coverage 60.48% 60.48%
========================================
Files 14 14
Lines 1516 1516
========================================
Hits 917 917
Misses 599 599 |
Co-authored-by: Dilan Pathirana <[email protected]>
Add .readthedocs.yaml and pin some documentation dependencies. More recent versions of nbsphin/sphinx/nbconvert require newer pandoc than available on the RTD ubuntu-images. :eyes: https://petab-select--63.org.readthedocs.build/en/63/ Closes #7
dilpath
approved these changes
Nov 7, 2023
| @@ -89,12 +89,16 @@ def absolute_links(txt): | |||
| # 'pypesto @ git+https://github.com/ICB-DCM/pyPESTO.git@develop#egg=pypesto', | |||
| ], | |||
| 'doc': [ | |||
| 'sphinx>=3.5.3', | |||
| 'sphinx>=3.5.3,<7', | |||
There was a problem hiding this comment.
Can this <7 be removed when the lower # pin comment is removed?
If so then
Suggested change
| 'sphinx>=3.5.3,<7', | |
| # remove <7 when below nbsphinx==0.9.1 and nbconvert<7.5.0 are unpinned | |
| 'sphinx>=3.5.3,<7', |
There was a problem hiding this comment.
Honestly, I don't know. It's usually trial-and-error with the documentation stack... 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .readthedocs.yaml and pin some documentation dependencies.
👀 https://petab-select--63.org.readthedocs.build/en/63/
Closes #7