New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating candidate space fails for version 0.1.12 #82

Closed

sebapersson opened this issue Feb 11, 2024 · 1 comment

sebapersson commented Feb 11, 2024

For the latest version of petab-select PEtab.jl errors. Running on Python 3.10 it boils down to:

select_problem = petab_select.Problem.from_yaml("petab_select_problem.yaml")
cs = petab_select.ui.candidates(problem=select_problem, criterion=select_problem.criterion)

Yielding the error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/sebpe/anaconda3/envs/PeTab/lib/python3.10/site-packages/petab_select/ui.py", line 99, in candidates
    predecessor_model.get_criterion(
AttributeError: 'NoneType' object has no attribute 'get_criterion'

Everything worked prior to version 0.1.12 (noticed this once I managed to get PyCall workng on GitHub CI).

I used the petab-select problem file from here.

dilpath added a commit that referenced this issue


          fix #82

c4f41a1

dilpath closed this as completed in

46ad30a

Member

dilpath commented Feb 22, 2024 •

edited

Loading

Thanks for reporting! Fixed now. This kind of error will be caught when the calibration tests are re-introduced soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment