Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store problem configuration in v2.Problem #338

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 9, 2024

Introduces v2.Problem.config which contains the info from the PEtab yaml file. The same as #326, but for v2.Problem.

Introduces `v2.Problem.config` which contains the info from the PEtab yaml file.
The same as PEtab-dev#326, but for `v2.Problem`.
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (4a551a7) to head (40c6c69).

Files with missing lines Patch % Lines
petab/v2/problem.py 97.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    74.38%   74.51%   +0.12%     
===========================================
  Files           53       53              
  Lines         5196     5222      +26     
  Branches       910      910              
===========================================
+ Hits          3865     3891      +26     
  Misses         984      984              
  Partials       347      347              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review December 9, 2024 15:13
@dweindl dweindl requested a review from a team as a code owner December 9, 2024 15:13
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fine to merge as-is

petab/v2/problem.py Outdated Show resolved Hide resolved
description="The path to the PEtab problem configuration.",
exclude=True,
)
base_path: str | AnyUrl | None = Field(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer just root but fine as is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My association with root would be that the other files are somewhere below in the hierarchy, and root/.. would be illegal. This is not the case here. It might be just my association, though. I am open to change it later on if others will strong about it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root is used as the location to which all other things are relative here:
https://docs.python.org/3/library/shutil.html#shutil.make_archive

But I think others will have varying opinions about the difference between root and base so fine 👍

Co-authored-by: Dilan Pathirana <[email protected]>
@dweindl dweindl merged commit d7f7e3a into PEtab-dev:develop Dec 9, 2024
7 checks passed
@dweindl dweindl deleted the problem_config_v2 branch December 9, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants