-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store problem configuration in v2.Problem
#338
Conversation
Introduces `v2.Problem.config` which contains the info from the PEtab yaml file. The same as PEtab-dev#326, but for `v2.Problem`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #338 +/- ##
===========================================
+ Coverage 74.38% 74.51% +0.12%
===========================================
Files 53 53
Lines 5196 5222 +26
Branches 910 910
===========================================
+ Hits 3865 3891 +26
Misses 984 984
Partials 347 347 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Fine to merge as-is
description="The path to the PEtab problem configuration.", | ||
exclude=True, | ||
) | ||
base_path: str | AnyUrl | None = Field( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer just root
but fine as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My association with root
would be that the other files are somewhere below in the hierarchy, and root/..
would be illegal. This is not the case here. It might be just my association, though. I am open to change it later on if others will strong about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root
is used as the location to which all other things are relative here:
https://docs.python.org/3/library/shutil.html#shutil.make_archive
But I think others will have varying opinions about the difference between root
and base
so fine 👍
Co-authored-by: Dilan Pathirana <[email protected]>
Introduces
v2.Problem.config
which contains the info from the PEtab yaml file. The same as #326, but forv2.Problem
.