Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some inconsistencies in the README #72

Merged
merged 2 commits into from
Aug 13, 2023
Merged

fix some inconsistencies in the README #72

merged 2 commits into from
Aug 13, 2023

Conversation

jmtatsch
Copy link
Contributor

partially fixes #71

@jmtatsch
Update README.md
0fc75f3 
fix outdated python version
fix inconsistent ggml model path
@jmtatsch
Merge pull request #1 from jmtatsch/jmtatsch-patch-1
98a55a9 
Update README.md
@PABannier
Copy link
Owner

Thanks @jmtatsch !

@PABannier PABannier merged commit e1d40fe into PABannier:main Aug 13, 2023
@jmtatsch
Copy link
Contributor Author

Always happy to help.
Could you please point me to the correct vocab.txt?

@PABannier
Copy link
Owner

PABannier commented Aug 13, 2023 •
edited
Loading

@jmtatsch You can obtain it by downloading the tokenizer bert-multilingual-case from HuggingFace. This is what bark uses. I'm wondering if I shouldn't push it directly in ggml_weights. At least for now since we only support bark. WDYT?

@jmtatsch
Copy link
Contributor Author

I always like it as easy as possible for the end user which should net the most users and thus the most contributions.
Also it reduces the potential amount of issues the user will open up ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PABannier PABannier PABannier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some broken things for first timers
2 participants
@jmtatsch @PABannier