Fix example server and add use gpu instruction in readme #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PABannier
requested changes
Jul 15, 2024
examples/server/server.cpp
Outdated
| std::string hostname = "127.0.0.1"; | ||
| std::string public_path = "examples/server/public"; | ||
| int32_t port = 1337; | ||
| int32_t read_timeout = 600; | ||
| int32_t write_timeout = 600; | ||
| }; | ||
|
|
||
| struct bark_params { | ||
| int32_t n_threads = std::min(1, static_cast<int32_t>(std::thread::hardware_concurrency())); | ||
| // struct bark_params { |
There was a problem hiding this comment.
rm the comments if no longer used
examples/server/server.cpp
Outdated
| bool model_req = false; | ||
| for (int i = 1; i < argc; i++) { | ||
| for (int i = 1; i < argc; i++) | ||
| { |
There was a problem hiding this comment.
We favour the curly braces on the same line as the statement. Please revert these changes.
Suggested change
| { | |
| for (int i = 1; i < argc; i++) { |
| std::string dest_wav_path = "/tmp/bark_tmp.wav"; | ||
| bark_generate_audio(bctx, text.c_str(), params.n_threads); | ||
| // generate audio |
There was a problem hiding this comment.
Fixed all these as requested.
|
@goriri Thanks for the PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.