New pr to update MailKit, ideally replacing #8746 #8768
Conversation
| @@ -116,7 +106,11 @@ public class SmtpMessageChannel : Component, ISmtpChannel, IDisposable { | |||
| mailMessage.ReplyTo.AddRange(ParseRecipients(emailMessage.ReplyTo)); | |||
| } | |||
|
|
|||
| _smtpClientField.Value.Send(mailMessage); | |||
| using (var smtpClient = CreateSmtpClient()) { | |||
There was a problem hiding this comment.
Might be worth having an overload which takes multiple emails to reuse the client, otherwise bulk-sending them will create as many connections.
|
Please merge the latest 1.10.x to fix the build error. |
|
@AndreaPiovanelli @MatteoPiovanelli-Laser would you like to continue working on this or #8746? |
# Conflicts: # src/Orchard.Web/Modules/Orchard.Email/packages.config
MatteoPiovanelli-Laser
force-pushed
the
mailkit_upgrade_fix
branch
from
07c0e64 to
1f92bd0
Compare
|
I've rebased this one as well. At this point I'm just hoping either of the PRs passes github's checks |
|
Is there any particular reason why you didn't update to the latest version at the time? It looks like that 4.4.0 or 4.5.0 was already out. EDIT: I see you wrote this in the other PR's description:
|
This should replace #8746 starting from the up-to-date 1.10.x branch.