Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8822: Upgrading MailKit to 4.8.0 and consolidating all NuGet packages #8823

Open
wants to merge 1 commit into
base: 1.10.x
Choose a base branch
from
Open

#8822: Upgrading MailKit to 4.8.0 and consolidating all NuGet packages #8823

wants to merge 1 commit into from

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented Dec 9, 2024 •
edited
Loading

Previous attempts are #8746 and #8768.

  • Updated MailKit to the latest, 4.8.0 version.
  • Consolidated all NuGet packages. Referencing different versions might have been the cause behind the runtime errors mentioned in the other PRs.
  • Testing process: Modified the Email Test functionality (EmailAdminController.TestSettings) to send the test email 1000 times and sent 150 paragraphs (91 KB) of lorem ipsum; multiple times. The same SmtpClient is being reused correctly. Also did a run of 10000 iterations, but Papercut didn't like that too much. :D

@BenedekFarkas BenedekFarkas added this to the Orchard 1.10.4 milestone Dec 9, 2024
@BenedekFarkas BenedekFarkas self-assigned this Dec 9, 2024
@BenedekFarkas BenedekFarkas linked an issue Dec 9, 2024 that may be closed by this pull request
Upgrade MailKit to the latest compatible version #8822
Open
@BenedekFarkas
Copy link
Member Author

FYI @AndreaPiovanelli @MatteoPiovanelli-Laser, please check if it works in your application as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenedekFarkas BenedekFarkas

Labels
needs testing
Projects
None yet
Milestone
Orchard 1.10.4
Development

Successfully merging this pull request may close these issues.

Upgrade MailKit to the latest compatible version
1 participant
@BenedekFarkas