Update grelfunctions.md with Tip for Date functions #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thadguidry
commented
Apr 14, 2024
•
thadguidry
commented
- Adds TIP to mention that Date functions only work with Strings or Dates, not Numbers. As witnessed with user https://forum.openrefine.org/t/only-year-please/1453?u=thadguidry
- Adds TIP to mention that Date functions only work with Strings or Dates, not Numbers. As witnessed with user https://forum.openrefine.org/t/only-year-please/1453?u=thadguidry
thadguidry
added
the
documentation
✅ Deploy Preview for openrefine-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tfmorris
requested changes
Apr 24, 2024
There was a problem hiding this comment.
This represents a bug in the implementation, so is not something we should document.
There is code in ToDate to check for Longs and convert them to Strings, but I suspect perhaps the user data had Integers instead. Whatever the cause, we should fix the bug and add test coverage, rather than documenting it.
|
Closing based on @tfmorris assessment. We can always come back to address updating the docs once bug is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.