Correction to file path error messaging #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small bug fix to improve the error messaging when aviary cannot find a file path.
Aviary now correctly displays the 'relative' path that was searched.
Related Issues
No issue number - discovered and fixed whilst debugging an Aviary aircraft model.
Details:
Aviary searches for 'path' in following order:
After each block of logic 'path' is overwritten so the next 'if' can determine whether 'path' exists.
The relative path string wasn't saved, and so the error message unhelpfully displayed the aviary_based path twice e.g:
FileNotFoundError: File not found in absolute path: concepts_library/a320neo/propulsion/aviaryPW1127G_eng_deck.csv, relative path: C:\Users\user\Git\Aviary\aviary\concepts_library\a320neo\propulsion\aviaryPW1127G_eng_deck.csv, or Aviary-based path: C:\Users\user\Git\Aviary\aviary\concepts_library\a320neo\propulsion\aviaryPW1127G_eng_deck.csv
This PR fixes the issue by saving the relative path string so that the error message can help the user identify where aviary is actually looking for the file:
FileNotFoundError: File not found in absolute path: concepts_library/a320neo/propulsion/aviaryPW1127G_eng_deck.csv, relative path: C:\Users\user\Git\ConceptsLibrary\concepts_library\a320neo\concepts_library\a320neo\propulsion\aviaryPW1127G_eng_deck.csv, or Aviary-based path: C:\Users\user\Git\Aviary\aviary\concepts_library\a320neo\propulsion\aviaryPW1127G_eng_deck.csv
Backwards incompatibilities
None
New Dependencies
None