Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi stream support #6

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

cidrblock
Copy link
Contributor

@cidrblock cidrblock commented Nov 17, 2023

image

  • Duplicate stations when a station has more than one media type, bit rate, or scheme
  • Switch from XML based OMPL to json
  • Add bit rate and media type to json and table CLI output
  • Remove the broad try/except for stream resolution to expose real errors, if this becomes and issue, the error can be logged later
  • Switch to https for search URL
  • Try both http and https for station stream resolution, several Cloudflare 403 errors were encountered during test and this should help avoid that to some degree
  • Some formatting cleanup

Improved error handling and logging will be added in a future PR

@cidrblock cidrblock marked this pull request as draft November 17, 2023 13:28
@cidrblock cidrblock marked this pull request as ready for review November 17, 2023 14:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@d5b1dd0). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev      #6   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       6           
  Lines          ?     215           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     215           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cidrblock cidrblock closed this May 27, 2024
@JarbasAl
Copy link
Member

apologies, this one got buried in my notifications, just noticed due to it being closed.

the changes look good and i will try to test soon, thanks!

@JarbasAl JarbasAl reopened this May 27, 2024
@JarbasAl JarbasAl added the enhancement New feature or request label May 27, 2024
@JarbasAl JarbasAl merged commit 7b4578a into OpenJarbas:dev May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants