-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add File Interface #1708
Add File Interface #1708
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
==========================================
- Coverage 76.80% 76.66% -0.15%
==========================================
Files 531 608 +77
Lines 42258 46532 +4274
Branches 270 842 +572
==========================================
+ Hits 32458 35675 +3217
- Misses 9800 10761 +961
- Partials 0 96 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to test this on Windows, Mac and Linux with mounted volumes to really know how it's working
|
||
def read_interface | ||
while true | ||
if @filef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
class FileInterface < Interface | ||
# @param command_write_folder [String] Folder to write command files to | ||
# @param telemetry_read_folder [String] Folder to read telemetry files from | ||
# @param telemetry_archive_folder [String] Folder to move read telemetry files to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment: "Set to DELETE to remove read telemetry file"
module OpenC3 | ||
class FileInterface < Interface | ||
# @param command_write_folder [String] Folder to write command files to | ||
# @param telemetry_read_folder [String] Folder to read telemetry files from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment: "Set to nil to disallow reads"
|
||
module OpenC3 | ||
class FileInterface < Interface | ||
# @param command_write_folder [String] Folder to write command files to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment: "Set to nil to disallow writes"
end | ||
|
||
def get_next_telemetry_file | ||
Dir.glob("#{@telemetry_read_folder}/*").sort[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be recursive? /**/*
Quality Gate passedIssues Measures |
No description provided.