Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Interface #1708

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Add File Interface #1708

merged 4 commits into from
Dec 8, 2024

Conversation

ryanmelt
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.66%. Comparing base (4c901c6) to head (b290e2c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   76.80%   76.66%   -0.15%     
==========================================
  Files         531      608      +77     
  Lines       42258    46532    +4274     
  Branches      270      842     +572     
==========================================
+ Hits        32458    35675    +3217     
- Misses       9800    10761     +961     
- Partials        0       96      +96     
Flag Coverage Δ
python 84.30% <ø> (-0.02%) ⬇️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt requested a review from jmthomas November 14, 2024 22:47
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to test this on Windows, Mac and Linux with mounted volumes to really know how it's working


def read_interface
while true
if @filef
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

class FileInterface < Interface
# @param command_write_folder [String] Folder to write command files to
# @param telemetry_read_folder [String] Folder to read telemetry files from
# @param telemetry_archive_folder [String] Folder to move read telemetry files to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment: "Set to DELETE to remove read telemetry file"

module OpenC3
class FileInterface < Interface
# @param command_write_folder [String] Folder to write command files to
# @param telemetry_read_folder [String] Folder to read telemetry files from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment: "Set to nil to disallow reads"


module OpenC3
class FileInterface < Interface
# @param command_write_folder [String] Folder to write command files to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment: "Set to nil to disallow writes"

end

def get_next_telemetry_file
Dir.glob("#{@telemetry_read_folder}/*").sort[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be recursive? /**/*

Copy link

sonarcloud bot commented Dec 8, 2024

@ryanmelt ryanmelt merged commit 7e206e2 into main Dec 8, 2024
27 of 28 checks passed
@ryanmelt ryanmelt deleted the file_interface branch December 8, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants