Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global_extent wrong when pixel_buffer in source constraints #334

Open
jdries opened this issue Dec 6, 2024 · 0 comments
Open

global_extent wrong when pixel_buffer in source constraints #334

jdries opened this issue Dec 6, 2024 · 0 comments
Assignees
@jdries

Comments

@jdries
Copy link
Contributor

jdries commented Dec 6, 2024

When processes apply a 'pixel_buffer', this is not taken into account when determining global bounds in the dry run.
It is however taken into account when constructing layoutdefinition, which is necessary because otherwise spatial keys could get negative.

As a result, we get cubes with different layoutdefinition, and thus slower merge_cubes + extra resample_cube_spatial.
@jdries jdries self-assigned this Dec 6, 2024
jdries added a commit that referenced this issue Dec 6, 2024
@jdries
take pixel buffer into account for global extent
b08018f 
#334
@jdries jdries mentioned this issue Dec 6, 2024
Merged
jdries added a commit that referenced this issue Dec 6, 2024
@jdries
take pixel buffer into account for global extent
bab14bc 
#334
jdries added a commit that referenced this issue Dec 6, 2024
@jdries
take pixel buffer into account for global extent
eae9c8e 
#334
jdries added a commit that referenced this issue Dec 6, 2024
@jdries
take pixel buffer into account for global extent
7c81172 
#334
jdries added a commit that referenced this issue Dec 9, 2024
@jdries
take pixel buffer into account for global extent
015acfa 
#334
jdries added a commit that referenced this issue Dec 9, 2024
@jdries
take pixel buffer into account for global extent
79370a1 
#334
jdries added a commit that referenced this issue Dec 9, 2024
@jdries
take pixel buffer into account for global extent (#335)
dbbee36 
* take pixel buffer into account for global extent
#334

* take pixel buffer into account for global extent
#334

* take pixel buffer into account for global extent
#334

* take pixel buffer into account for global extent
#334

* take pixel buffer into account for global extent
#334

* take pixel buffer into account for global extent
#334
EmileSonneveld added a commit that referenced this issue Dec 9, 2024
@EmileSonneveld
Only align when spatial extent makes sense. This should fix tests. #334
6f29912
EmileSonneveld added a commit that referenced this issue Dec 9, 2024
@EmileSonneveld
Revert "Only align when spatial extent makes sense. This should fix t…
aebff1f 
…ests. #334"

This reverts commit 6f29912.
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 reproject bbox before applying buffer, add resample to mask
2c30733
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 to_scl_dilation_mask should block resampling params
bd12ebc
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 test fixes
3c05b3e
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 add test
ac62833
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 fix test
18ed5a2
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 extra check on actual resampling
7a2e2e1
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 test fixes
741a0f0
jdries added a commit that referenced this issue Dec 17, 2024
@jdries
#334 global extent buffer
21e6151 
* #334 reproject bbox before applying buffer, add resample to mask

* #334 to_scl_dilation_mask should block resampling params

* #334 test fixes

* #334 add test

* #334 fix test

* #334 extra check on actual resampling

* #334 test fixes
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 take resolution into account when applying buffer
f41d9fd
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
a29d2dc
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
30907e5
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
64c7e3e
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
63fc808
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
dca68b4
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
7427360
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
c716ad2
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
1a02da8
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
2b9fcab
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
9e0c9bf
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
13e14bc
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
aaffbe5
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
3e970fa
jdries added a commit that referenced this issue Dec 18, 2024
@jdries
#334 compute geometry bbox in target crs if possible
46be389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdries jdries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdries