Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the creator cli to the public repo but exclude it from the published package #15

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Move the creator cli to the public repo but exclude it from the published package #15

merged 6 commits into from
Nov 30, 2023

Conversation

ponyjackal
Copy link
Contributor

@ponyjackal ponyjackal commented Nov 30, 2023 •
edited
Loading

fix OU-1162
fix OU-1163
fix OU-1159
fix OU-1183

@ponyjackal ponyjackal requested a review from pcowgill November 30, 2023 13:20
@linear Linear
Copy link

linear bot commented Nov 30, 2023

OU-1162 When running CLI command to generate a contextualizer in the context repo, it should use types from the correct dir in that repo

Screenshot 2023-11-29 at 4.57.51 PM.png

OU-1161 When running CLI command to generate a contextualizer in the ou-api repo, it should use types from the @once-upon/evm-context package

Screenshot 2023-11-29 at 4.57.51 PM.png

OU-1163 The handlebars template for the contextualizer should use the format prettier desires

Screenshot 2023-11-29 at 4.59.39 PM.png

Screenshot 2023-11-29 at 4.59.47 PM.png

OU-1159 CLI script for generating a contextualizer should print the expected arguments if you run it without any

Screenshot 2023-11-29 at 4.54.55 PM.png

OU-1168 Move the generator CLI to the public repo and ensure it doesn't get included in the npm package

https://docs.npmjs.com/cli/v10/using-npm/developers#keeping-files-out-of-your-package

@pcowgill pcowgill changed the title Move the generator cli to the public repo and ensure it Move the creator cli to the public repo and ensure it Nov 30, 2023
@pcowgill pcowgill changed the title Move the creator cli to the public repo and ensure it Move the creator cli to the public repo but exclude it from the published package Nov 30, 2023
@linear Linear
Copy link

linear bot commented Nov 30, 2023

OU-1183 In the generated contextualizer, the type of 70 as a number and the expected type of string should match

Screenshot 2023-11-30 at 10.14.08 AM.png

@pcowgill pcowgill merged commit 58c759e into main Nov 30, 2023
2 checks passed
@pcowgill pcowgill deleted the benguyen0214/ou-1168-move-the-generator-cli-to-the-public-repo-and-ensure-it branch November 30, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcowgill pcowgill pcowgill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponyjackal @pcowgill