Revert "InMobi: mtype support (prebid#3921)"

This reverts commit 9740a91.
Ogury · Oct 30, 2024 · 831d1a4 · 831d1a4
1 parent 4d0d8e0
commit 831d1a4
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 133 deletions.
diff --git a/adapters/inmobi/inmobi.go b/adapters/inmobi/inmobi.go
@@ -77,10 +77,7 @@ func (a *InMobiAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalR
 
 	for _, sb := range serverBidResponse.SeatBid {
 		for i := range sb.Bid {
-			mediaType, err := getMediaTypeForImp(sb.Bid[i])
-			if err != nil {
-				return nil, []error{err}
-			}
+			mediaType := getMediaTypeForImp(sb.Bid[i].ImpID, internalRequest.Imp)
 			bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
 				Bid:     &sb.Bid[i],
 				BidType: mediaType,
@@ -121,17 +118,18 @@ func preprocess(imp *openrtb2.Imp) error {
 	return nil
 }
 
-func getMediaTypeForImp(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
-	switch bid.MType {
-	case openrtb2.MarkupBanner:
-		return openrtb_ext.BidTypeBanner, nil
-	case openrtb2.MarkupVideo:
-		return openrtb_ext.BidTypeVideo, nil
-	case openrtb2.MarkupNative:
-		return openrtb_ext.BidTypeNative, nil
-	default:
-		return "", &errortypes.BadServerResponse{
-			Message: fmt.Sprintf("Unsupported mtype %d for bid %s", bid.MType, bid.ID),
+func getMediaTypeForImp(impId string, imps []openrtb2.Imp) openrtb_ext.BidType {
+	mediaType := openrtb_ext.BidTypeBanner
+	for _, imp := range imps {
+		if imp.ID == impId {
+			if imp.Video != nil {
+				mediaType = openrtb_ext.BidTypeVideo
+			}
+			if imp.Native != nil {
+				mediaType = openrtb_ext.BidTypeNative
+			}
+			break
 		}
 	}
+	return mediaType
 }
diff --git a/adapters/inmobi/inmobitest/exemplary/simple-app-banner.json b/adapters/inmobi/inmobitest/exemplary/simple-app-banner.json
@@ -75,8 +75,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "bannerhtml",
-                "impid": "imp-id",
-                "mtype": 1
+                "impid": "imp-id"
               }
             ]
           }
@@ -95,7 +94,6 @@
         "adm": "bannerhtml",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 1,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-app-native.json b/adapters/inmobi/inmobitest/exemplary/simple-app-native.json
@@ -73,8 +73,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "native-json",
-                "impid": "imp-id",
-                "mtype": 4
+                "impid": "imp-id"
               }
             ]
           }
@@ -93,7 +92,6 @@
         "adm": "native-json",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 4,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-app-video.json b/adapters/inmobi/inmobitest/exemplary/simple-app-video.json
@@ -77,8 +77,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
-                "impid": "imp-id",
-                "mtype": 2
+                "impid": "imp-id"
               }
             ]
           }
@@ -97,7 +96,6 @@
         "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 2,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-web-banner.json b/adapters/inmobi/inmobitest/exemplary/simple-web-banner.json
@@ -73,8 +73,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "bannerhtml",
-                "impid": "imp-id",
-                "mtype": 1
+                "impid": "imp-id"
               }
             ]
           }
@@ -93,7 +92,6 @@
         "adm": "bannerhtml",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 1,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-web-native.json b/adapters/inmobi/inmobitest/exemplary/simple-web-native.json
@@ -71,8 +71,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "native-json",
-                "impid": "imp-id",
-                "mtype": 4
+                "impid": "imp-id"
               }
             ]
           }
@@ -91,7 +90,6 @@
         "adm": "native-json",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 4,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-web-video.json b/adapters/inmobi/inmobitest/exemplary/simple-web-video.json
@@ -75,8 +75,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
-                "impid": "imp-id",
-                "mtype": 2
+                "impid": "imp-id"
               }
             ]
           }
@@ -95,7 +94,6 @@
         "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 2,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/supplemental/banner-format-coersion.json b/adapters/inmobi/inmobitest/supplemental/banner-format-coersion.json
@@ -81,8 +81,7 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "bannerhtml",
-                "impid": "imp-id",
-                "mtype": 1
+                "impid": "imp-id"
               }
             ]
           }
@@ -101,7 +100,6 @@
         "adm": "bannerhtml",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
-        "mtype": 1,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/supplemental/invalid-mtype.json b/adapters/inmobi/inmobitest/supplemental/invalid-mtype.json