Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add challenge 49 #1651

Merged
merged 4 commits into from
Oct 3, 2024
Merged

feat: add challenge 49 #1651

merged 4 commits into from
Oct 3, 2024

Conversation

adarsh-a-tw
Copy link
Contributor

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Adds Challenge 49

Relations

Closes #713

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@adarsh-a-tw adarsh-a-tw requested a review from commjoen October 3, 2024 05:29
bendehaan
bendehaan reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, nice addition! Some minor textual nits

src/main/resources/explanations/challenge49_reason.adoc Outdated Show resolved Hide resolved
src/main/resources/explanations/challenge49_reason.adoc Outdated Show resolved Hide resolved
commjoen
commjoen approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fantastic challenge! merging it in!

@commjoen commjoen merged commit d604053 into OWASP:master Oct 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendehaan bendehaan bendehaan left review comments

@commjoen commjoen commjoen approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Challenge: use weak KDF to protect a secret
3 participants
@adarsh-a-tw @commjoen @bendehaan