Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#809 Vault sidecar challenge2 #1405

Merged
merged 19 commits into from
May 22, 2024
Merged

#809 Vault sidecar challenge2 #1405

merged 19 commits into from
May 22, 2024

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented May 19, 2024

What kind of changes does this PR include?

  • Fixes or refactors : fixes missing annotations in docs for challenge46
  • A new challenge: adds last vault based challenge
  • Additional documentation: fixes missing annotations in docs for challenge46
  • Something else

Description

Creates challenge 47 with vault injection debugging issues and updates challenge 46 with the right content, including for cloud-envs.

Relations

Closes #809

Checklist:

TODOS:

  • Fix challenge46: make sure that the printfs are being called
  • Fix challenge46: update texts
  • Fix challenge47: update texts
  • Fix challenge46/47 k8s annotations for cloud envs
  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen marked this pull request as ready for review May 21, 2024 09:36
@commjoen commjoen changed the title Draft: 809 sidecar challenge2 #809 Vault sidecar challenge2 May 21, 2024
@commjoen commjoen requested a review from bendehaan May 22, 2024 04:16
@commjoen commjoen merged commit f126a58 into master May 22, 2024
16 of 17 checks passed
@commjoen commjoen deleted the 809-sidecar branch May 22, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a misconfigured vault template where someone left a secret in besides some values actually being injected
2 participants