Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for challenge 16 FE/BE alignment and fix for showing the minimal needed tech. #1272

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Mar 4, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Fixes challenge16 by updating the generation script and using jquery to load the script preventing it to be cached again

Relations

Fixes #1191

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen requested a review from bendehaan as a code owner March 4, 2024 21:53
@commjoen commjoen changed the title Fix for challenge 16 FE/BE allignment Fix for challenge 16 FE/BE alignment and fix for showing the minimal needed tech. Mar 5, 2024
@commjoen commjoen merged commit 1c95f0f into master Mar 5, 2024
15 checks passed
@commjoen commjoen deleted the fix-16 branch March 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in challenge 16
2 participants