Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes: eslint, broken animation, contributors, and more challenges links #1242

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Feb 18, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

This PR undoes the animation introduced in the previous PR, fixes eslint rules, adds missing contributors on home and readme, and adds texts that show that there are more challenges in case you hit a "disabled" challenge.

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen requested a review from bendehaan as a code owner February 18, 2024 09:19
@commjoen commjoen merged commit 12d37ae into master Feb 21, 2024
14 of 15 checks passed
@commjoen commjoen deleted the enable_eslintruls branch February 21, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants