Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issues regarding challenge rendering #1133

Merged
merged 18 commits into from
Dec 13, 2023
Merged

Fix for issues regarding challenge rendering #1133

merged 18 commits into from
Dec 13, 2023

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Dec 12, 2023 •
edited
Loading

What kind of changes does this PR include?

Description

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen changed the title Adding tests to detect okteto issues Fix for issues :) Dec 12, 2023
@commjoen commjoen changed the title Fix for issues :) Fix for issues regarding challenge rendering Dec 12, 2023
commjoen and others added 14 commits December 12, 2023 13:43
@commjoen
Fix for actuator
c4b0f2a
@commjoen
Update POM file with new version: 1.8.0RC7
745838c
@commjoen
Merge branch 'master' into hotfix-k8s-okteto
bb43b00
@commjoen
update okteto to check issue
40fa40f
fix: add missing environment to the challenge
d743594 
This way we first look if the challenge specifies are `missing_environment` key. If not, we fall back to the environments `missing_environment` warning.
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
55cd89b
fix: Render error message about missing env
c981b2e 
Precompile the `.adoc` files to html and use the right location to include them.
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
1d3d7fc
@commjoen
Update POM file with new version: 1.8.0RC9
197666c
@commjoen
test ofr rc9
4a22153
@commjoen
Final updates
c4a2c74
@commjoen
Merge branch 'master' into hotfix-k8s-okteto
3f0eacd
fix: render only asciidoc from explanations
d1d4f47 
You can specify multiple directories in the plugin, they have to be separate executions in Maven.

Since all are in the same directory removing the second source directory
@commjoen
Created RC11 for a better setup
c8f821a
@commjoen commjoen marked this pull request as ready for review December 13, 2023 09:36
@commjoen commjoen requested a review from bendehaan as a code owner December 13, 2023 09:36
@commjoen commjoen merged commit eaf9925 into master Dec 13, 2023
15 of 16 checks passed
@commjoen commjoen deleted the hotfix-k8s-okteto branch December 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendehaan bendehaan Awaiting requested review from bendehaan bendehaan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@commjoen